Method fromEvmAddress() fails to return the contract id from long zero address #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
requested review from
SimiHunjan,
ochikov and
petreze
as code owners
svetoslav-nikol0v
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2018 +/- ##
===========================================
+ Coverage 76.12% 83.77% +7.65%
===========================================
Files 304 304
Lines 75854 75854
===========================================
+ Hits 57746 63550 +5804
+ Misses 18108 12304 -5804 ☔ View full report in Codecov by Sentry. |
rokn
approved these changes
Nov 8, 2023
petreze
approved these changes
Nov 9, 2023
svetoslav-nikol0v
deleted the
1991-crash-when-trying-to-get-contractid-from-evmaddress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fromEvmAddress()method to return the correct contract id from long zero addressRelated issue(s):
Fixes #1991
Checklist